Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233AbVIEANo (ORCPT ); Sun, 4 Sep 2005 20:13:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932236AbVIEANo (ORCPT ); Sun, 4 Sep 2005 20:13:44 -0400 Received: from allen.werkleitz.de ([80.190.251.108]:6018 "EHLO allen.werkleitz.de") by vger.kernel.org with ESMTP id S932233AbVIEANn (ORCPT ); Sun, 4 Sep 2005 20:13:43 -0400 Date: Mon, 5 Sep 2005 02:13:36 +0200 From: Johannes Stezenbach To: Nish Aravamudan Cc: Andrew Morton , linux-kernel@vger.kernel.org, Oliver Endriss , Patrick Boettcher , Andrew de Quincey Message-ID: <20050905001336.GB20663@linuxtv.org> Mail-Followup-To: Johannes Stezenbach , Nish Aravamudan , Andrew Morton , linux-kernel@vger.kernel.org, Oliver Endriss , Patrick Boettcher , Andrew de Quincey References: <20050904232259.777473000@abc> <20050904232336.080662000@abc> <29495f1d05090416413caf9043@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29495f1d05090416413caf9043@mail.gmail.com> User-Agent: Mutt/1.5.10i X-SA-Exim-Connect-IP: 84.189.198.88 Subject: Re: [DVB patch 51/54] ttpci: av7110: RC5+ remote control support X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on allen.werkleitz.de) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 35 On Sun, Sep 04, 2005 Nish Aravamudan wrote: > On 9/4/05, Johannes Stezenbach wrote: > > --- linux-2.6.13-git4.orig/drivers/media/dvb/ttpci/av7110_ir.c 2005-09-04 22:03:40.000000000 +0200 > > +++ linux-2.6.13-git4/drivers/media/dvb/ttpci/av7110_ir.c 2005-09-04 22:31:00.000000000 +0200 > > @@ -7,16 +7,16 @@ > > #include > > > > #include "av7110.h" > > +#include "av7110_hw.h" > > > > -#define UP_TIMEOUT (HZ/4) > > +#define UP_TIMEOUT (HZ*7/25) > > Should this be > > #define UP_TIMEOUT msecs_to_jiffies(280) > > or > > #define UP_TIMEOUT (7*msecs_to_jiffies(40) > > ? I agree it's nicer to read, but AFAIK not required for correctness? If so, then we'll fix those up in linuxtv.org CVS and submit cleanup patches later. Thanks for your comments. Johannes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/