Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932241AbVIEA1i (ORCPT ); Sun, 4 Sep 2005 20:27:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932244AbVIEA1i (ORCPT ); Sun, 4 Sep 2005 20:27:38 -0400 Received: from allen.werkleitz.de ([80.190.251.108]:9346 "EHLO allen.werkleitz.de") by vger.kernel.org with ESMTP id S932242AbVIEA1h (ORCPT ); Sun, 4 Sep 2005 20:27:37 -0400 Date: Mon, 5 Sep 2005 02:27:32 +0200 From: Johannes Stezenbach To: Nish Aravamudan Cc: Andrew Morton , linux-kernel@vger.kernel.org, Oliver Endriss , Patrick Boettcher , Andrew de Quincey Message-ID: <20050905002732.GA20808@linuxtv.org> Mail-Followup-To: Johannes Stezenbach , Nish Aravamudan , Andrew Morton , linux-kernel@vger.kernel.org, Oliver Endriss , Patrick Boettcher , Andrew de Quincey References: <20050904232259.777473000@abc> <20050904232336.080662000@abc> <29495f1d05090416413caf9043@mail.gmail.com> <20050905001336.GB20663@linuxtv.org> <29495f1d05090417165837a07b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29495f1d05090417165837a07b@mail.gmail.com> User-Agent: Mutt/1.5.10i X-SA-Exim-Connect-IP: 84.189.198.88 Subject: Re: [DVB patch 51/54] ttpci: av7110: RC5+ remote control support X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on allen.werkleitz.de) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1493 Lines: 35 On Sun, Sep 04, 2005 Nish Aravamudan wrote: > On 9/4/05, Johannes Stezenbach wrote: > > On Sun, Sep 04, 2005 Nish Aravamudan wrote: > > > On 9/4/05, Johannes Stezenbach wrote: > > > > > > > > -#define UP_TIMEOUT (HZ/4) > > > > +#define UP_TIMEOUT (HZ*7/25) > > > > > > #define UP_TIMEOUT msecs_to_jiffies(280) > > > #define UP_TIMEOUT (7*msecs_to_jiffies(40) > > > > I agree it's nicer to read, but AFAIK not required for correctness? > > If so, then we'll fix those up in linuxtv.org CVS and submit > > cleanup patches later. > > Yeah, it's correct with the three current values of HZ (100, 250 and > 1000), but if you try a not-so-clean value (like Con did with 864, or > something), you might run into rounding issues. msecs_to_jiffies() > should take care of them (or will be a single point to do so > eventually). Well, if msecs_to_jiffies() is the new way of specifying timeouts we'd have a lot more to fix up in our tree. But something like a remote control key-up timeout doesn't need much precision. Generally I see nothing wrong with HZ/4, but something like HZ*20/1000 could be problematic with small or odd HZ values. Agreed? Or is it desired that people generally use msecs_to_jiffies()? Johannes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/