DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=GMlkaCxKFFv2d9MNNT6Azx7oK4/6gPJ98IsDvsldzgH8ubPr8BurzqESGh/N+Az5uYsC0v/4xT1uKaoanNQ2a5kwTNHw2hegqOifXDZNB3nI7y4z0aFzndAL2I8OiFIniiWVBH9NPy3lOCSSOhtR5gj5av9RyOVbz6eyjjb215A=
Message-ID: <df33fe7c050905072642a9c938@mail.gmail.com>
Date: Mon, 5 Sep 2005 16:26:21 +0200
From: Takis <panagiotis.issaris@gmail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] ipw2200: Missing kmalloc check
Cc: ipw2100-admin@linux.intel.com, linux-kernel@vger.kernel.org
In-Reply-To: <431C31A5.3080804@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
References: <1125886450.4017.14.camel@nyx> <431C31A5.3080804@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 847
Lines: 23

On 9/5/05, Jiri Slaby <jirislaby@gmail.com> wrote:
> >       rxq = (struct ipw_rx_queue *)kmalloc(sizeof(*rxq), GFP_KERNEL);
> >+      if (unlikely(!rxq)) {
> >+              IPW_ERROR("memory allocation failed\n");
> >+              return NULL;
> >+      }
> >       memset(rxq, 0, sizeof(*rxq));
> >
> >
> and use kzalloc instead of kmalloc and memset 0?

Yes, but Morton's tree hasn't got the ipw2200 yet, while Linus'
Linux-tree hasn't pulled in the patches containing kzalloc. I'll send
a new patch as soon as the kzalloc patch get in Linus' tree or ipw in
Marton's.

With friendly regards,
Takis
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/