Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750804AbVIFTCK (ORCPT ); Tue, 6 Sep 2005 15:02:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750808AbVIFTCK (ORCPT ); Tue, 6 Sep 2005 15:02:10 -0400 Received: from zproxy.gmail.com ([64.233.162.199]:13150 "EHLO zproxy.gmail.com") by vger.kernel.org with ESMTP id S1750803AbVIFTCI convert rfc822-to-8bit (ORCPT ); Tue, 6 Sep 2005 15:02:08 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=BG/RBzkFs+vnLHKfMOYVTiHInJwh/N8yVaazqSpd+MzoxwCnhshnw94D12X6jyEPZfVpikbiTIsF3d6XJqbMIprqEsV6Y1DoIZabnvDNL1fHAX+KbCqZHfWDfoHkyJWBGPzRzKJgfPAHn3tngggcnOnDsGL4swfOwogj0qou2sk= Message-ID: <4789af9e05090612023fb8517c@mail.gmail.com> Date: Tue, 6 Sep 2005 13:02:07 -0600 From: Jim Ramsay Reply-To: jim.ramsay@gmail.com To: Lukasz Kosewski Subject: Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2 Cc: Stefan Richter , Jeff Garzik , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <4789af9e0508291223435f174@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <355e5e5e05080103021a8239df@mail.gmail.com> <4789af9e050823124140eb924f@mail.gmail.com> <4789af9e050823154364c8e9eb@mail.gmail.com> <430BA990.9090807@mvista.com> <430BCB41.5070206@s5r6.in-berlin.de> <355e5e5e05082407031138120a@mail.gmail.com> <4789af9e05082408111c4a6294@mail.gmail.com> <4789af9e05082409121cc6870@mail.gmail.com> <4789af9e0508291223435f174@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 21 Regarding the sata_promise.c patch, I think I have found a bug in the interrupt handler: Just before the 'try_hotplug' label, you provide a check that will kick us out of the interrupt handler if the interrupt was just handled by a DMA command completing successfully. However, I have seen the occasion where a single IRQ is used to signal both a DMA completion AND a hotplug event. Of course in this case the hotplug event itself would be ignored completely. So I would recommend getting rid of that check entirely. -- Jim Ramsay "Me fail English? That's unpossible!" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/