Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751193AbVIGBvi (ORCPT ); Tue, 6 Sep 2005 21:51:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751192AbVIGBvi (ORCPT ); Tue, 6 Sep 2005 21:51:38 -0400 Received: from mail.dvmed.net ([216.237.124.58]:40682 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1751167AbVIGBvh (ORCPT ); Tue, 6 Sep 2005 21:51:37 -0400 Message-ID: <431E4799.7000502@pobox.com> Date: Tue, 06 Sep 2005 21:51:21 -0400 From: Jeff Garzik User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720) X-Accept-Language: en-us, en MIME-Version: 1.0 To: akpm@osdl.org CC: pavel@ucw.cz, ipw2100-admin@linux.intel.com, pavel@suse.cz, Linux Kernel , Netdev List Subject: Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging References: <200509062056.j86KuHcL031448@shell0.pdx.osdl.net> In-Reply-To: <200509062056.j86KuHcL031448@shell0.pdx.osdl.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 852 Lines: 25 akpm@osdl.org wrote: > From: Pavel Machek > > This removes debug prints from entry/exit of functions. Such level of > debugging should probably be done by gdb or similar. > > Signed-off-by: Pavel Machek > Cc: Jeff Garzik > Cc: "James P. Ketrenos" > Signed-off-by: Andrew Morton NAK. Rationale: maintainer's choice. Pavel doesn't get to choose the debugger of choice for the driver maintainer. I do this entry/exit stuff in my net and SATA drivers; printk is my primary method of debugging. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/