Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932559AbVIHBtV (ORCPT ); Wed, 7 Sep 2005 21:49:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932558AbVIHBtV (ORCPT ); Wed, 7 Sep 2005 21:49:21 -0400 Received: from mail.dvmed.net ([216.237.124.58]:47489 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932541AbVIHBtU (ORCPT ); Wed, 7 Sep 2005 21:49:20 -0400 Message-ID: <431F9899.4060602@pobox.com> Date: Wed, 07 Sep 2005 21:49:13 -0400 From: Jeff Garzik User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Linux Kernel Mailing List CC: Andrew Morton , Netdev List Subject: Re: [PATCH] 3c59x: read current link status from phy References: <200509080125.j881PcL9015847@hera.kernel.org> In-Reply-To: <200509080125.j881PcL9015847@hera.kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1378 Lines: 38 Linux Kernel Mailing List wrote: > tree 1771b690cdee80312ace3fe046e29e965a0b30eb > parent c8d127418d78aaeeb1a417ef7453dc09c9118146 > author Tommy S. Christensen Wed, 07 Sep 2005 05:17:28 -0700 > committer Linus Torvalds Thu, 08 Sep 2005 06:57:30 -0700 > > [PATCH] 3c59x: read current link status from phy > > The phy status register must be read twice in order to get the actual link > state. > > Signed-off-by: Tommy S. Christensen > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > > drivers/net/3c59x.c | 1 + > 1 files changed, 1 insertion(+) > > diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c > --- a/drivers/net/3c59x.c > +++ b/drivers/net/3c59x.c > @@ -1889,6 +1889,7 @@ vortex_timer(unsigned long data) > { > spin_lock_bh(&vp->lock); > mii_status = mdio_read(dev, vp->phys[0], 1); > + mii_status = mdio_read(dev, vp->phys[0], 1); It would be nice if somebody would be motivated to check in s/1/MII_BMSR/ to utilize the constant in include/linux/mii.h. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/