Date: Wed, 7 Sep 2005 22:23:47 -0700
From: Andrew Morton <akpm@osdl.org>
To: Miloslav Trmac <mitr@volny.cz>
Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Wistron laptop button driver
Message-Id: <20050907222347.493f1047.akpm@osdl.org>
In-Reply-To: <431E4E28.5020604@volny.cz>
References: <431E4E28.5020604@volny.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 34

Miloslav Trmac <mitr@volny.cz> wrote:
>
> +static void call_bios(struct regs *regs)
>  +{
>  +	unsigned long flags;
>  +
>  +	preempt_disable();
>  +	local_irq_save(flags);
>  +	asm volatile ("pushl %%ebp;"
>  +		      "movl %[data], %%ebp;"
>  +		      "call *%[routine];"
>  +		      "popl %%ebp"
>  +		      : "=a" (regs->eax), "=b" (regs->ebx), "=c" (regs->ecx)
>  +		      : "0" (regs->eax), "1" (regs->ebx), "2" (regs->ecx),
>  +			[routine] "m" (bios_entry_point),
>  +			[data] "m" (bios_data_map_base)
>  +		      : "edx", "edi", "esi", "memory");
>  +	local_irq_restore(flags);
>  +	preempt_enable();
>  +}
>  +

(the preempt_disable/enable isn't needed - local_irq_save() will suffice)

gcc-2.95.x spits the dummy over this [routine] stuff.  What compiler does
this require?

Is it necessary to open-code the BIOS call in the driver?  Does it make
sense to have some library function to do this?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/