Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751373AbVIHOmi (ORCPT ); Thu, 8 Sep 2005 10:42:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751377AbVIHOmi (ORCPT ); Thu, 8 Sep 2005 10:42:38 -0400 Received: from ip18.tpack.net ([213.173.228.18]:17092 "HELO mail.tpack.net") by vger.kernel.org with SMTP id S1751373AbVIHOmg (ORCPT ); Thu, 8 Sep 2005 10:42:36 -0400 Subject: Re: [PATCH] 3c59x: read current link status from phy From: Tommy Christensen To: Bogdan Costescu Cc: Jeff Garzik , Linux Kernel Mailing List , Andrew Morton , Netdev List In-Reply-To: References: <200509080125.j881PcL9015847@hera.kernel.org> <431F9899.4060602@pobox.com> <1126184700.4805.32.camel@tsc-6.cph.tpack.net> Content-Type: text/plain Message-Id: <1126190554.4805.68.camel@tsc-6.cph.tpack.net> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Thu, 08 Sep 2005 16:42:35 +0200 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 32 On Thu, 2005-09-08 at 15:35, Bogdan Costescu wrote: > On Thu, 8 Sep 2005, Tommy Christensen wrote: > > > The idea is to avoid an extra delay of 60 seconds before detecting > > link-up. > > But you are adding the read to a function that is called repeatedly to > fix an event that happens only once at start-up ! Link state can change anytime, not just at start-up. That's why it's being repeatedly monitored ;-) > If this read is really needed (I still doubt it...), can't it be > performed in vortex_up(), by possibly doubling the existing one there ? > vortex_up() is executed only once at start-up, not every 60 seconds. That won't solve the reported issue, unfortunately. Besides, how long would you like to wait for network connectivity after plugging in the cable? It is now lowered from [60-120] to [0-60] seconds. Personally, I'd prefer the delay to be < 10 seconds. -Tommy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/