Message-Id: <432073610200007800024489@emea1-mh.id2.novell.com>
Date: Thu, 08 Sep 2005 17:22:41 +0200
From: "Jan Beulich" <JBeulich@novell.com>
To: "Christoph Hellwig" <hch@infradead.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rmmod notifier chain
References: <43206EFE0200007800024451@emea1-mh.id2.novell.com> <20050908151624.GA11067@infradead.org>
In-Reply-To: <20050908151624.GA11067@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1095
Lines: 29

>>> Christoph Hellwig <hch@infradead.org> 08.09.05 17:16:24 >>>
>On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote:
>> (Note: Patch also attached because the inline version is certain to
get
>> line wrapped.)
>> 
>> Debugging and maintenance support code occasionally needs to know
not
>> only of module insertions, but also modulke removals. This adds a
>> notifier
>> chain for this purpose.
>
>I don't think this should be exported, _GPL if at all.

That one I can't decide upon; I just took the insertion notifier code
as baseline (which doesn't use _GPL).

>And it certainly shouldn't go in without an actual user.

That's funny - on one hand I'm asked to not submit huge patches (not by
you, but by others), but on the other hand not having the consuming code
in the same patch as the providing one is now deemed to be a problem.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/