Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965012AbVIHViI (ORCPT ); Thu, 8 Sep 2005 17:38:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965013AbVIHViI (ORCPT ); Thu, 8 Sep 2005 17:38:08 -0400 Received: from smtp.osdl.org ([65.172.181.4]:54975 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S965012AbVIHViH (ORCPT ); Thu, 8 Sep 2005 17:38:07 -0400 Date: Thu, 8 Sep 2005 14:37:42 -0700 (PDT) From: Linus Torvalds To: "David S. Miller" cc: rmk+lkml@arm.linux.org.uk, alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org, davem@redhat.com, akpm@osdl.org Subject: Re: Serial maintainership In-Reply-To: Message-ID: References: <20050908212236.A19542@flint.arm.linux.org.uk> <20050908.132634.88719733.davem@davemloft.net> <20050908.134259.51218842.davem@davemloft.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 19 On Thu, 8 Sep 2005, Linus Torvalds wrote: > > (You might even remove the #ifdef inside the function by then, since "ch" > being a constant zero will make 90% of it go away anyway). Sadly, the remaining part checks "port->sysrq", which doesn't even exist unless CONFIG_SERIAL_CORE_CONSOLE is set, so that doesn't work out. Oh, well. That simple three-liner should work fine, I was just hoping we could do the rest more cleanly.. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/