Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965227AbVIIBew (ORCPT ); Thu, 8 Sep 2005 21:34:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965230AbVIIBew (ORCPT ); Thu, 8 Sep 2005 21:34:52 -0400 Received: from az33egw01.freescale.net ([192.88.158.102]:3057 "EHLO az33egw01.freescale.net") by vger.kernel.org with ESMTP id S965227AbVIIBew (ORCPT ); Thu, 8 Sep 2005 21:34:52 -0400 In-Reply-To: <1126223767.29803.34.camel@gaston> References: <1126223767.29803.34.camel@gaston> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Cc: "Gala Kumar K.-galak" , "Paul Mackerras" , , , "linuxppc64-dev" Content-Transfer-Encoding: 7bit From: Kumar Gala Subject: Re: [PATCH] ppc: Merge tlb.h Date: Thu, 8 Sep 2005 20:34:52 -0500 To: Benjamin Herrenschmidt X-Mailer: Apple Mail (2.734) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1589 Lines: 48 On Sep 8, 2005, at 6:56 PM, Benjamin Herrenschmidt wrote: > On Thu, 2005-09-08 at 16:11 -0500, Kumar Gala wrote: > >> Merged tlb.h between asm-ppc32 and asm-ppc64 into asm-powerpc. Also, >> > fixed > >> a compiler warning in arch/ppc/mm/tlb.c since it was roughly related. >> >> Signed-off-by: Kumar K. Gala >> > > Do we want to do that ? > > Replacing 2 different files with one split in #ifdef isn't a > progress... > As I said, I think we need two subdirs for the low level stuffs > that is > different, and that includes at this point all of the memory > management > related stuff. I understand, but I'm also not sure if its progress to duplicate a major of a file that is common. In this case it might be better handled by having specific versions per "sub-arch". I think the key is determining which files should be handled via sub-arch diffs and which should be handled via ifdef's in the file. Some cases like ppc_asm are so similar that it seems better to have a single file and ifdef the specific case. > In addition, I'd appreciate if we could avoid touching ppc64 mm > related > files completely for a couple of weeks as I'm working on a fairly big > patch that I'm really tired of having to rebase all the time ;) Will avoid touch any other mm related headers than :) - kumar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/