To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, jbeulich@novell.com
Subject: Re: [PATCH] re-export genapic on i386
References: <4320793602000078000244D9@emea1-mh.id2.novell.com>
	<20050908155011.GA12359@infradead.org>
From: Andi Kleen <ak@suse.de>
Date: 09 Sep 2005 05:53:04 +0200
In-Reply-To: <20050908155011.GA12359@infradead.org>
Message-ID: <p73u0gu3nj3.fsf@verdi.suse.de>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1390
Lines: 29

Christoph Hellwig <hch@infradead.org> writes:

> On Thu, Sep 08, 2005 at 05:47:34PM +0200, Jan Beulich wrote:
> > (Note: Patch also attached because the inline version is certain to get
> > line wrapped.)
> > 
> > A change not too long ago made i386's genapic symbol no longer be
> > exported,
> > and thus certain low-level functions no longer be usable. Since
> > close-to-
> > the-hardware code may still be modular, this rectifies the situation.
> 
> Again, what code would use it, why and why can't it use a proper accessor.
> And a shitty thousands of lines out ot tree debugger ported from Novell's
> legacy OS is not the answer, btw.

Why not?  Most debuggers will always be out of tree for political
reasons, and because of that the normal "every hook must 
have an in tree user" rule cannot be strictly applied to them.

It's also not reasonable to ask these people to always 
carry big patchkits around - after all they just want
to debug core kernel code, and it is very ugly to apply
a big patchkit just for that.

So as long as the hooks for external modular debuggers 
are reasonable and _GPL I think they should be merged.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/