Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030242AbVIILPi (ORCPT ); Fri, 9 Sep 2005 07:15:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030243AbVIILPi (ORCPT ); Fri, 9 Sep 2005 07:15:38 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:6888 "EHLO mail.cs.helsinki.fi") by vger.kernel.org with ESMTP id S1030242AbVIILPh (ORCPT ); Fri, 9 Sep 2005 07:15:37 -0400 Date: Fri, 9 Sep 2005 14:15:23 +0300 (EEST) From: Pekka J Enberg To: Anton Altaparmakov cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net Subject: Re: [PATCH 2/25] NTFS: Allow highmem kmalloc() in ntfs_malloc_nofs() and add _nofail() version. In-Reply-To: <1126263740.24291.16.camel@imp.csi.cam.ac.uk> Message-ID: References: <84144f0205090903366454da6@mail.gmail.com> <1126263740.24291.16.camel@imp.csi.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 20 On Fri, 9 Sep 2005, Anton Altaparmakov wrote: > Also note I only use the ntfs_malloc_nofs() wrapper if I have to. If I > know how much I am allocating or at least know that the maximum is quite > small, I use kmalloc() directly. It is pretty much only for the runlist > allocations that I use the wrapper as the runlist is typically small but > for fragmented files it can grow huge. I have seen runlists consuming > over 256kiB of ram, without vmalloc that would be a real problem... So things like rl = ntfs_malloc_nofs(rlsize = PAGE_SIZE); should be changed to kmalloc(), right? Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/