Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932510AbVIIMCs (ORCPT ); Fri, 9 Sep 2005 08:02:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932520AbVIIMCs (ORCPT ); Fri, 9 Sep 2005 08:02:48 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:18048 "EHLO mail.cs.helsinki.fi") by vger.kernel.org with ESMTP id S932510AbVIIMCr (ORCPT ); Fri, 9 Sep 2005 08:02:47 -0400 Date: Fri, 9 Sep 2005 15:02:43 +0300 (EEST) From: Pekka J Enberg To: Anton Altaparmakov cc: linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH 2/25] NTFS: Allow highmem kmalloc() in ntfs_malloc_nofs() and add _nofail() version. In-Reply-To: <1126266702.32261.5.camel@imp.csi.cam.ac.uk> Message-ID: References: <84144f0205090903366454da6@mail.gmail.com> <1126263740.24291.16.camel@imp.csi.cam.ac.uk> <1126265138.24291.21.camel@imp.csi.cam.ac.uk> <1126266508.32261.3.camel@imp.csi.cam.ac.uk> <1126266702.32261.5.camel@imp.csi.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 21 On Fri, 9 Sep 2005, Anton Altaparmakov wrote: > > I completely disagree with you given that this is not "inventing [...] > > own memory allocators", it is just a convenient short hand. I am sure a > > lot of people would agree with you though. It is just a matter of > > personal preference. > > I should add that this is not ntfs only, the idea is from another file > system which uses it, too. Can't remember which one it was, though (xfs > maybe?). Indeed. It is not just a matter of personal preference but also a matter of subsystems introducing duplicate code like this. Quick grepping shows UDF doing same thing and XFS doing slightly differently but I am pretty sure I've seen it elsewhere too. Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/