Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030218AbVIIQZp (ORCPT ); Fri, 9 Sep 2005 12:25:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751426AbVIIQZp (ORCPT ); Fri, 9 Sep 2005 12:25:45 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:9155 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S1751422AbVIIQZp (ORCPT ); Fri, 9 Sep 2005 12:25:45 -0400 Date: Fri, 9 Sep 2005 18:25:00 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: "Brown, Len" cc: Andi Kleen , akpm@osdl.org, Borislav Petkov , acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: RE: [PATCH] [2.6.13-mm2] set IBM ThinkPad extras to default n in Kconfig In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1448 Lines: 39 Hi, On Fri, 9 Sep 2005, Brown, Len wrote: > >--- drivers/acpi/Kconfig.orig 2005-09-09 09:46:26.000000000 +0200 > >+++ drivers/acpi/Kconfig 2005-09-09 09:46:46.000000000 +0200 > >@@ -197,7 +197,7 @@ config ACPI_ASUS > > config ACPI_IBM > > tristate "IBM ThinkPad Laptop Extras" > > depends on X86 > >- default y > >+ default n > > ---help--- > > This is a Linux ACPI driver for the IBM ThinkPad > > Before we had "default m", since that is how a distro > is expected to compile this, and other, "ACPI drivers". > > But we got complaits that _nothing_ should be "default m", > so I changed it to "default y". Maybe that was simplistic -- > button should be "default y", but the platform drivers should > all be "default n"? > > I'm not sure what to do here -- what use-model > should we tune default Kconfig for? The best would be to avoid using defaults completely, unless the resulting kernel is non-functional (e.g. it doesn't compile or boot). So far it's still the responsibility of the user to explicitly turn everything on he needs (at least until we have a functional autoconfig). BTW distros are not the only users, from them I would expect how to configure a kernel. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/