Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932576AbVIITAL (ORCPT ); Fri, 9 Sep 2005 15:00:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932583AbVIITAL (ORCPT ); Fri, 9 Sep 2005 15:00:11 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:5539 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932576AbVIITAK (ORCPT ); Fri, 9 Sep 2005 15:00:10 -0400 Date: Fri, 9 Sep 2005 20:00:07 +0100 From: Christoph Hellwig To: Christoph Hellwig , Hans Reiser , Andrew Morton , LKML , Reiserfs developers mail-list , ReiserFS List Subject: Re: List of things requested by lkml for reiser4 inclusion (to review) Message-ID: <20050909190007.GA12109@infradead.org> Mail-Followup-To: Christoph Hellwig , Hans Reiser , Andrew Morton , LKML , Reiserfs developers mail-list , ReiserFS List References: <200509091817.39726.zam@namesys.com> <4321C806.60404@namesys.com> <20050909185740.GA11923@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050909185740.GA11923@infradead.org> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 26 On Fri, Sep 09, 2005 at 07:57:40PM +0100, Christoph Hellwig wrote: > A very annoying small thing that comes to mind is the usage of > reiser4_internal. Please remove it, all but exported symbol are > module-private. Oh, one other things that's totally annoying and makes reading the code a pain are the line-length and comment style. Please wrap lines after 80 chars and use normal /* foobar, blagg */ or /* * fvsfafsfasdrfasddddddddddddddddddddd * fdsfsfdsfsdf * sdfsdfs */ comments, thanks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/