Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030453AbVIIWQc (ORCPT ); Fri, 9 Sep 2005 18:16:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030720AbVIIWQc (ORCPT ); Fri, 9 Sep 2005 18:16:32 -0400 Received: from smtp.osdl.org ([65.172.181.4]:37309 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1030453AbVIIWQb (ORCPT ); Fri, 9 Sep 2005 18:16:31 -0400 Date: Fri, 9 Sep 2005 15:15:37 -0700 (PDT) From: Linus Torvalds To: Paul Jackson cc: Andrew Morton , Simon Derr , linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset semaphore depth check deadlock fix In-Reply-To: <20050909220116.26993.9674.sendpatchset@jackhammer.engr.sgi.com> Message-ID: References: <20050909220116.26993.9674.sendpatchset@jackhammer.engr.sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 21 On Fri, 9 Sep 2005, Paul Jackson wrote: > > This patch fixes this deadlock by wrapping the up() and down() > calls on cpuset_sem in kernel/cpuset.c with code that tracks > the nesting depth of the current task on that semaphore, We _really_ don't want to have function names like "cs_up()" and "cs_down()". Please either call them something half-way readable, like "cpuset_lock()" and "cpuset_unlock()". Yes, it's a local static function, but still.. No need to be cryptic about it. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/