Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932609AbVIIWhi (ORCPT ); Fri, 9 Sep 2005 18:37:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932608AbVIIWhh (ORCPT ); Fri, 9 Sep 2005 18:37:37 -0400 Received: from smtp.osdl.org ([65.172.181.4]:1219 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932609AbVIIWhh (ORCPT ); Fri, 9 Sep 2005 18:37:37 -0400 Date: Fri, 9 Sep 2005 15:37:16 -0700 (PDT) From: Linus Torvalds To: Greg KH cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: [GIT PATCH] More PCI patches for 2.6.13 In-Reply-To: <20050909220758.GA29746@kroah.com> Message-ID: References: <20050909220758.GA29746@kroah.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 25 On Fri, 9 Sep 2005, Greg KH wrote: > > Dave Jones: > must_check attributes for PCI layer. Why? This only clutters up the compile, hiding real errors. I think all those compile warnings are totally bogus. Who really cares? Are they going to be fixed, or were they added just to irritate people? We should have a strict rule: anybody who adds things like "must_check" and "deprecated" had better also be ready and willing to fix all the new warnings they cause - you're not allowed to just assume that "somebody else will fix it". Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/