Date: Fri, 9 Sep 2005 15:54:21 -0700
From: Greg KH <gregkh@suse.de>
To: Linus Torvalds <torvalds@osdl.org>, davej@codemonkey.org.uk,
       arjan@infradead.org
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
       linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [GIT PATCH] More PCI patches for 2.6.13
Message-ID: <20050909225421.GA31433@suse.de>
References: <20050909220758.GA29746@kroah.com> <Pine.LNX.4.58.0509091535180.3051@g5.osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.58.0509091535180.3051@g5.osdl.org>
User-Agent: Mutt/1.5.10i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1167
Lines: 36

On Fri, Sep 09, 2005 at 03:37:16PM -0700, Linus Torvalds wrote:
> 
> 
> On Fri, 9 Sep 2005, Greg KH wrote:
> > 
> > Dave Jones:
> >   must_check attributes for PCI layer.
> 
> Why?

This is something that David and Arjan wanted in.  Guys?

> This only clutters up the compile, hiding real errors.
> 
> I think all those compile warnings are totally bogus. Who really cares? 
> Are they going to be fixed, or were they added just to irritate people?

I fixed up all of the PCI core and USB drivers that were flagged by
these warnings already.  Biggest area left is network drivers that I
saw.

> We should have a strict rule: anybody who adds things like "must_check"
> and "deprecated" had better also be ready and willing to fix all the new
> warnings they cause - you're not allowed to just assume that "somebody
> else will fix it".

Fair enough.  Dave and Arjan, want to fix up the rest of the tree?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/