Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932646AbVIJAWd (ORCPT ); Fri, 9 Sep 2005 20:22:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932638AbVIJAWd (ORCPT ); Fri, 9 Sep 2005 20:22:33 -0400 Received: from smtp.osdl.org ([65.172.181.4]:478 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1030404AbVIJAWc (ORCPT ); Fri, 9 Sep 2005 20:22:32 -0400 Date: Fri, 9 Sep 2005 17:22:17 -0700 (PDT) From: Linus Torvalds To: Andrew Morton cc: gregkh@suse.de, davej@codemonkey.org.uk, arjan@infradead.org, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: [GIT PATCH] More PCI patches for 2.6.13 In-Reply-To: <20050909163634.21afe4ca.akpm@osdl.org> Message-ID: References: <20050909220758.GA29746@kroah.com> <20050909225421.GA31433@suse.de> <20050909163634.21afe4ca.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 813 Lines: 22 On Fri, 9 Sep 2005, Andrew Morton wrote: > > If something like a PCI power management function fails then it will likely > cause suspend or resume to malfunction, and we have a lot of such problems. No, for several reasons. First off, some of those functions can't fail in normal usage. Thus telling people that they have to check the return code is insane. Secondly, at least some of the suspend failures have historically been because drivers returned errors for no good reason. Adding yet another broken reason to return error is not going to help. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/