Date: Sat, 10 Sep 2005 02:33:37 -0700
From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
       Christoph Lameter <clameter@sgi.com>
Subject: Re: NUMA mempolicy /proc code in mainline shouldn't have been
 merged
Message-Id: <20050910023337.7b79db9a.akpm@osdl.org>
In-Reply-To: <200509101120.19236.ak@suse.de>
References: <200509101120.19236.ak@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1224
Lines: 35

Andi Kleen <ak@suse.de> wrote:
>
>  Just noticed the ugly SGI /proc/*/numa_maps code got merged.

Been in -mm for over two months.

>  I argued several times against it

OK, I either didn't notice or forgot to make a note of that.

> and I very deliberately didn't include
>  a similar facility when I wrote the NUMA policy code because it's a bad
>  idea.
> 
> 
>  - it's a lot of ugly code.
>  - it's basically only a debugging hack right now
>  - it presents lots of kernel internal information and mempolicy
>  internals (like how many people have a page mapped) etc.
>  to userland that shouldn't be exposed to this.
>  - the format is very complicated and the chance of bug free
>  userland parsers of this is near zero.
>  - there is no demonstrated application that needs it
>  (there was a theoretical usecase where it might be needed,
>  but there were better solutions proposed for this) 
> 
> 
>  Can the patch please be removed? 

OK by me.  I queued a revert patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/