Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932138AbVIJSdz (ORCPT ); Sat, 10 Sep 2005 14:33:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932149AbVIJSdy (ORCPT ); Sat, 10 Sep 2005 14:33:54 -0400 Received: from ra.tuxdriver.com ([24.172.12.4]:59403 "EHLO ra.tuxdriver.com") by vger.kernel.org with ESMTP id S932138AbVIJSdy (ORCPT ); Sat, 10 Sep 2005 14:33:54 -0400 Date: Sat, 10 Sep 2005 14:33:04 -0400 From: "John W. Linville" To: Linus Torvalds Cc: Greg KH , davej@codemonkey.org.uk, arjan@infradead.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: [GIT PATCH] More PCI patches for 2.6.13 Message-ID: <20050910183302.GA6311@tuxdriver.com> Mail-Followup-To: Linus Torvalds , Greg KH , davej@codemonkey.org.uk, arjan@infradead.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz References: <20050909220758.GA29746@kroah.com> <20050909225421.GA31433@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 855 Lines: 22 On Fri, Sep 09, 2005 at 04:22:25PM -0700, Linus Torvalds wrote: > the return value of "pci_enable_wake()" for example. There's really no > real reason to ever care, as far as I can tell - if it fails, there's > nothing you can really do about it anyway. > > Also, in general, the fact is that things like "pci_set_power_state()" > might fail in _theory_, but we just don't care. A driver that doesn't But, aren't these arguments for changing the functions to return void? If there is never any point in checking the results, then why have results at all? John -- John W. Linville linville@tuxdriver.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/