Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932206AbVIJSy3 (ORCPT ); Sat, 10 Sep 2005 14:54:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932209AbVIJSy3 (ORCPT ); Sat, 10 Sep 2005 14:54:29 -0400 Received: from smtp.osdl.org ([65.172.181.4]:44224 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932206AbVIJSy1 (ORCPT ); Sat, 10 Sep 2005 14:54:27 -0400 Date: Sat, 10 Sep 2005 11:53:59 -0700 (PDT) From: Linus Torvalds To: "John W. Linville" cc: Greg KH , davej@codemonkey.org.uk, arjan@infradead.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: [GIT PATCH] More PCI patches for 2.6.13 In-Reply-To: <20050910183302.GA6311@tuxdriver.com> Message-ID: References: <20050909220758.GA29746@kroah.com> <20050909225421.GA31433@suse.de> <20050910183302.GA6311@tuxdriver.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 21 On Sat, 10 Sep 2005, John W. Linville wrote: > > But, aren't these arguments for changing the functions to return void? > If there is never any point in checking the results, then why have > results at all? Trying to set other power states than D0 might return interesting values. Also, you _can_ use the value to determine whether the device supports PM states at all. There are tons of functions that return values. That doesn't mean that you always have to check them. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/