Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292AbVIJUqJ (ORCPT ); Sat, 10 Sep 2005 16:46:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932293AbVIJUqJ (ORCPT ); Sat, 10 Sep 2005 16:46:09 -0400 Received: from dns.kernelconcepts.de ([212.60.202.194]:50693 "EHLO gateway.kernelconcepts.de") by vger.kernel.org with ESMTP id S932292AbVIJUqI (ORCPT ); Sat, 10 Sep 2005 16:46:08 -0400 Message-ID: <432345CB.4010402@kernelconcepts.de> Date: Sat, 10 Sep 2005 22:44:59 +0200 From: Nils Faerber User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050727) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jiri Slaby CC: Greg KH , Linux Kernel Mailing List , linux-pci@atrey.karlin.mff.cuni.cz, nils@kernelconcepts.de Subject: Re: [PATCH 10/10] drivers/char: pci_find_device remove (drivers/char/watchdog/i8xx_tco.c) References: <200509101221.j8ACLAOV017267@localhost.localdomain> <43233ED6.2080101@gmail.com> In-Reply-To: <43233ED6.2080101@gmail.com> X-Enigmail-Version: 0.92.0.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1614 Lines: 59 Thanks, looks fine to me so I added my signed-off. Jiri Slaby wrote: > Cc: nils@kernelconcepts.de [maintainer] > > Jiri Slaby napsal(a): > >> Signed-off-by: Jiri Slaby Signed-off-by: Nils Faerber >> i8xx_tco.c | 5 +++-- >> 1 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/char/watchdog/i8xx_tco.c >> b/drivers/char/watchdog/i8xx_tco.c >> --- a/drivers/char/watchdog/i8xx_tco.c >> +++ b/drivers/char/watchdog/i8xx_tco.c >> @@ -414,12 +414,11 @@ static unsigned char __init i8xx_tco_get >> * Find the PCI device >> */ >> >> - while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != >> NULL) { >> + for_each_pci_dev(dev) >> if (pci_match_id(i8xx_tco_pci_tbl, dev)) { >> i8xx_tco_pci = dev; >> break; >> } >> - } >> >> if (i8xx_tco_pci) { >> /* >> @@ -535,6 +534,8 @@ static void __exit watchdog_cleanup (voi >> misc_deregister (&i8xx_tco_miscdev); >> unregister_reboot_notifier(&i8xx_tco_notifier); >> release_region (TCOBASE, 0x10); >> + >> + pci_dev_put(i8xx_tco_pci); >> } >> >> module_init(watchdog_init); >> >> > Cheers nils faerber -- kernel concepts Tel: +49-271-771091-12 Dreisbachstr. 24 Fax: +49-271-771091-19 D-57250 Netphen Mob: +49-176-21024535 -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/