Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932333AbVIJWxm (ORCPT ); Sat, 10 Sep 2005 18:53:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932320AbVIJWxm (ORCPT ); Sat, 10 Sep 2005 18:53:42 -0400 Received: from smtp.osdl.org ([65.172.181.4]:57566 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932319AbVIJWxl (ORCPT ); Sat, 10 Sep 2005 18:53:41 -0400 Date: Sat, 10 Sep 2005 15:53:27 -0700 (PDT) From: Linus Torvalds To: Andrew Morton cc: Jeff Garzik , dwmw2@infradead.org, stern@rowland.harvard.edu, Greg KH , Linux Kernel Mailing List , Dave Airlie , Pavel Machek Subject: Re: [GIT PATCH] More PCI patches for 2.6.13 In-Reply-To: <20050910153110.36a44eba.akpm@osdl.org> Message-ID: References: <43235707.7050909@pobox.com> <20050910153110.36a44eba.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 39 On Sat, 10 Sep 2005, Andrew Morton wrote: > > Who do I bug about these longstanding ppc64 warnings, btw ;) > > drivers/scsi/sata_svw.c: In function `k2_sata_tf_load': > drivers/scsi/sata_svw.c:111: warning: passing arg 2 of `eeh_writeb' makes pointer from integer without a cast > drivers/scsi/sata_svw.c:116: warning: passing arg 2 of `eeh_writew' makes pointer from integer without a cast > drivers/scsi/sata_svw.c:117: warning: passing arg 2 of `eeh_writew' makes pointer from integer without a cast I used to have a patch to fix them, and sent it to Jeff ages ago. At that point, he didn't want to use the iomap() functionality, but maybe that has changed. Jeff? It requires making almost all the SATA IO base pointers be iomapped: the current struct ata_ioports { unsigned long cmd_addr; unsigned long data_addr; ... would have to become struct ata_ioports { void __iomem *cmd_addr; void __iomem *data_addr; ... instead - and initialized with the proper ioport_map() or pci_iomap() as appropriate. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/