Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964915AbVIKLgI (ORCPT ); Sun, 11 Sep 2005 07:36:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932516AbVIKLgI (ORCPT ); Sun, 11 Sep 2005 07:36:08 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:41869 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S932504AbVIKLgG (ORCPT ); Sun, 11 Sep 2005 07:36:06 -0400 Date: Sun, 11 Sep 2005 13:33:56 +0200 From: Pavel Machek To: Linus Torvalds Cc: "John W. Linville" , Greg KH , davej@codemonkey.org.uk, arjan@infradead.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: [GIT PATCH] More PCI patches for 2.6.13 Message-ID: <20050911113356.GB2742@elf.ucw.cz> References: <20050909220758.GA29746@kroah.com> <20050909225421.GA31433@suse.de> <20050910183302.GA6311@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 859 Lines: 22 Hi! > > But, aren't these arguments for changing the functions to return void? > > If there is never any point in checking the results, then why have > > results at all? > > Trying to set other power states than D0 might return interesting values. > Also, you _can_ use the value to determine whether the device supports PM > states at all. Perhaps we should make pci_set_power_state(pdev, PCI_D0) to succeed in case of old device not supporting power managment? As you've said, it is effectively in PCI_D0 anyway ;-). Pavel -- if you have sharp zaurus hardware you don't need... you know my address - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/