From: Michal Semler <cijoml@volny.cz>
Reply-To: cijoml@volny.cz
To: linux-kernel@vger.kernel.org
Subject: pluto2 patch
Date: Sun, 11 Sep 2005 21:04:10 +0200
User-Agent: KMail/1.7.2
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-2"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200509112104.12953.cijoml@volny.cz>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1529
Lines: 44

Hi,

I receive about 200 dmesg messages in 1 minut this fixes it, I think we can 
easily remove this error message:

--- /usr/src/linux/drivers/media/dvb/pluto2/pluto2.c ? ?2005-09-11 
14:09:19.000000000 +0200
+++ /usr/src/linux/drivers/media/dvb/pluto2/pluto2.c ? ?2005-09-11 
14:10:17.000000000 +0200
@@ -291,8 +291,8 @@
? ? ? ? ? ? ? ? ? ? ? ? i += 188;
? ? ? ? ? ? ? ? valid = i / 188;
? ? ? ? ? ? ? ? if (nbpackets != valid) {
- ? ? ? ? ? ? ? ? ? ? ? dev_err(&pluto->pdev->dev, "nbpackets=%u valid=%u\n",
- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? nbpackets, valid);
+ ? ? ? /* ? ? ? ? ? ? ?dev_err(&pluto->pdev->dev, "nbpackets=%u valid=%u\n",
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? nbpackets, valid); */
? ? ? ? ? ? ? ? ? ? ? ? nbpackets = valid;
? ? ? ? ? ? ? ? }
? ? ? ? }

Thanks for applying!

There is another bug when card is removed, driver says card hung many times.
This part of code is responsible for it:

? ? ? ? if (tscr == 0xffffffff) {
? ? ? ? ? ? ? ? // FIXME: maybe recover somehow
? ? ? ? ? ? ? ? dev_err(&pluto->pdev->dev, "card hung up :(\n");
? ? ? ? ? ? ? ? return IRQ_HANDLED;

There should be probably 
????????????????if (tscr == 0xffffffff) && !pcmcia_card_removed
to fix this.

Do anybody know exact name of this funtion in pcmcia code? 

Thanks
Michal
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/