Message-Id: <4325412D0200007800024DE1@emea1-mh.id2.novell.com>
Date: Mon, 12 Sep 2005 08:49:49 +0200
From: "Jan Beulich" <JBeulich@novell.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rmmod notifier chain
References: <43206EFE0200007800024451@emea1-mh.id2.novell.com> <20050908151624.GA11067@infradead.org> <432073610200007800024489@emea1-mh.id2.novell.com> <20050908184659.6aa5a136.akpm@osdl.org> <43219FDF0200007800024975@emea1-mh.id2.novell.com> <20050909112721.316f2dbb.akpm@osdl.org>
In-Reply-To: <20050909112721.316f2dbb.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1416
Lines: 48

>I cherrypicked five of your patches yesterday as ones which look like
they
>should be in 2.6.14.
>
>	fix i386 cmpxchg
>	adjust .version updating
>	free initrd mem adjustment
>	constify font data
>	minor fbcon_scroll adjustment
>
>But none of those are NMI-related.  Specifically which patch are you
>referring to?

http://marc.theaimsgroup.com/?l=linux-kernel&m=112600003916210&w=2

>...

>>  I'd be curious to know how you, considering yourself in my
position,
>>  would have approached breaking up and submitting that size a
patch.
>
>a) Patches which affect the main kernel but which aren't really
>   debugger-related

So it was right to start with those...

>b) Patches which affect the main kernel and which are
debugger-related
>   (adding hooks, generalising interfaces, refactoring functions,
etc).

... and some of those. But you saying this was more or less the right
approach puts things in contradiction with the complaints from others
that consumers of some of the changes weren't immediately visible.

>c) Finally, one monster patch to add the debugger functionality. 
Maybe
>   split into in vger-sized chunks.

That'll have to follow later.

Thanks, Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/