Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750807AbVILNBx (ORCPT ); Mon, 12 Sep 2005 09:01:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750810AbVILNBx (ORCPT ); Mon, 12 Sep 2005 09:01:53 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:22742 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S1750807AbVILNBw (ORCPT ); Mon, 12 Sep 2005 09:01:52 -0400 Date: Mon, 12 Sep 2005 15:01:48 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Andi Kleen cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, discuss@x86-64.org Subject: Re: [1/3] Add 4GB DMA32 zone In-Reply-To: <200509121454.37220.ak@suse.de> Message-ID: References: <43246267.mailL4R11PXCB@suse.de> <200509121447.00373.ak@suse.de> <200509121454.37220.ak@suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 32 Hi, On Mon, 12 Sep 2005, Andi Kleen wrote: > > On Mon, 12 Sep 2005, Andi Kleen wrote: > > > > > -#define MAX_NR_ZONES 3 /* Sync this with ZONES_SHIFT */ > > > > > -#define ZONES_SHIFT 2 /* ceil(log2(MAX_NR_ZONES)) */ > > > > > +#define MAX_NR_ZONES 4 /* Sync this with ZONES_SHIFT */ > > > > > +#define ZONES_SHIFT 3 /* ceil(log2(MAX_NR_ZONES)) */ > > > > > > > > Why needs ZONES_SHIFT to be increased? > > > > > > > > > -#define FLAGS_RESERVED 8 > > > > > +#define FLAGS_RESERVED 9 > > > > > > > > I would prefer to keep this at 8. > > > > > > sparsemem needs these two. > > > > What two? What are you talking about??? > > The two changes you quoted. Sorry, but I still don't see why. Could you _please_ be a little more verbose? Thanks. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/