Date: Mon, 12 Sep 2005 13:23:52 -0700
From: Andrew Morton <akpm@osdl.org>
To: Kirill Korotaev <dev@sw.ru>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, xemul@sw.ru,
       Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH] error path in setup_arg_pages() misses
 vm_unacct_memory()
Message-Id: <20050912132352.6d3a0e3a.akpm@osdl.org>
In-Reply-To: <4325B188.10404@sw.ru>
References: <4325B188.10404@sw.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 804
Lines: 19

Kirill Korotaev <dev@sw.ru> wrote:
>
>  This patch fixes error path in setup_arg_pages() functions, since it 
>  misses vm_unacct_memory() after successful call of 
>  security_vm_enough_memory(). Also it cleans up error path.

Ugh.  The identifier `security_vm_enough_memory()' sounds like some
predicate which has no side-effects.  Except it performs accounting.  Hence
bugs like this.

It's a shame that you mixed a largeish cleanup along with a bugfix - please
don't do that in future.

Patch looks OK to me.  Hugh, could you please double-check sometime?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/