Date: Mon, 12 Sep 2005 15:44:28 -0700
From: Andrew Morton <akpm@osdl.org>
To: michal.k.k.piotrowski@gmail.com
Cc: alexn@telia.com, linux-kernel@vger.kernel.org
Subject: Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness
 in vsnprintf
Message-Id: <20050912154428.7026eff7.akpm@osdl.org>
In-Reply-To: <6bffcb0e05091214133c189d05@mail.gmail.com>
References: <20050912024350.60e89eb1.akpm@osdl.org>
	<6bffcb0e050912044856628995@mail.gmail.com>
	<20050912175433.GA8574@localhost.localdomain>
	<6bffcb0e05091214133c189d05@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 32

Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
>
> Hi,
> 
> On 12/09/05, Alexander Nyberg <alexn@telia.com> wrote:
> > 
> > Gah, I'm such a fantastic programmer.
> > 
> > I don't know what mc is up to but the error checking in read_page_owner
> > is flawed wrt snprintf which could cause the 'size' argument to snprintf
> > to become negative and if so overwrite beyond 'buf'.
> > 
> > Again, I fail to see how mc causes this to happen, but this fixes it
> > by proper error checking.
> > 
> > Signed-off-by: Alexander Nyberg <alexn@telia.com>
> 
> Thanks, patch solved problem.

Thanks.

> Here is version, that clean apply on 2.6.13-mm3. Can you review it?

That patch is all wordwrapped.

How doe sit differe from Alex's patch?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/