Date: Mon, 12 Sep 2005 23:42:00 -0700
From: Andrew Morton <akpm@osdl.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, penberg@cs.helsinki.fi, jirislaby@gmail.com,
       lion.vollnhals@web.de
Subject: Re: [PATCH] use kzalloc instead of malloc+memset
Message-Id: <20050912234200.10b2abe7.akpm@osdl.org>
In-Reply-To: <200509130033.11109.dtor_core@ameritech.net>
References: <200509130010.38483.lion.vollnhals@web.de>
	<43260817.7070907@gmail.com>
	<84144f0205091221431827b126@mail.gmail.com>
	<200509130033.11109.dtor_core@ameritech.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 34

Dmitry Torokhov <dtor_core@ameritech.net> wrote:
>
> On Monday 12 September 2005 23:43, Pekka Enberg wrote:
> > On 9/13/05, Jiri Slaby <jirislaby@gmail.com> wrote:
> > > >-      cls = kmalloc(sizeof(struct class), GFP_KERNEL);
> > > >+      cls = kzalloc(sizeof(struct class), GFP_KERNEL);
> > > >
> > > >
> > > maybe, the better way is to write `*cls' instead of `struct class',
> > > better for further changes
> > 
> > Please note that some maintainers don't like it. I at least could not
> > sneak in patches like these to drivers/usb/ because I had changed
> > sizeof.
> > 
> 
> And given the fact that Greg maintains driver core it probably won't be
> accepted here either :)
> 
> FWIW I also prefer spelling out the structure I am allocating.
> 

It hurts readability.  Quick question: is this code correct?

	dev = kmalloc(sizeof(struct net_device), GFP_KERNEL);

you don't know.  You have to go hunting down the declaration of `dev' to
find out.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/