Date: Tue, 13 Sep 2005 15:12:46 +0100
From: Christoph Hellwig <hch@infradead.org>
To: J?rn Engel <joern@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: Missing #include <config.h>
Message-ID: <20050913141246.GA3234@infradead.org>
Mail-Followup-To: Christoph Hellwig <hch@infradead.org>,
	J?rn Engel <joern@infradead.org>, linux-kernel@vger.kernel.org
References: <20050913135622.GA30675@phoenix.infradead.org> <20050913150825.A23643@flint.arm.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050913150825.A23643@flint.arm.linux.org.uk>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 926
Lines: 21

On Tue, Sep 13, 2005 at 03:08:26PM +0100, Russell King wrote:
> On Tue, Sep 13, 2005 at 02:56:23PM +0100, J?rn Engel wrote:
> > After spending some hours last night and this morning hunting a bug,
> > I've found that a different include order made a difference.  Some
> > files don't work correctly, unless config.h is included before.
> 
> I'm still of the opinion that we should add
> 
> 	-imacros include/linux/config.h
> 
> to the gcc command line and stop bothering with trying to get
> linux/config.h included into the right files and not in others.
> (which then means we can eliminate linux/config.h from all files.)

Yes, absolutely.  That would help fixing lots of mess.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/