Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965110AbVINJbf (ORCPT ); Wed, 14 Sep 2005 05:31:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965112AbVINJbf (ORCPT ); Wed, 14 Sep 2005 05:31:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:11214 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S965110AbVINJbf (ORCPT ); Wed, 14 Sep 2005 05:31:35 -0400 Date: Wed, 14 Sep 2005 11:31:33 +0200 Message-ID: From: Takashi Iwai To: Roland Dreier Cc: akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] add PCI IDs so RME32 and RME96 drivers build In-Reply-To: <52r7bs2tm2.fsf@cisco.com> References: <52r7bs2tm2.fsf@cisco.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta18) (chestnut) (+CVS-20041021) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1414 Lines: 40 At Tue, 13 Sep 2005 20:52:53 -0700, Roland Dreier wrote: > > While doing an allyesconfig build, I noticed that the commit > > commit 8cdfd2519c6c9a1e6057dc5970b2542b35895738 > Author: Takashi Iwai > Date: Wed Sep 7 14:08:11 2005 +0200 > > [ALSA] Remove superfluous PCI ID definitions > > broke the RME32 and RME96 drivers, since the PCI IDs they use seem to > have changed names. Here's a patch to fix this -- compile tested > only, since I have no idea what the hardware even is. > > > Fix the build of the RME32 and RME96 drivers by having them use the > PCI_DEVICE_ID_RME_xxx names defined in instead of > the PCI_DEVICE_ID_xxx names that they used to define themselves. > > Also fix the typo in the id PCI_DEVICE_IDRME__DIGI96_8_PAD_OR_PST > so the name is PCI_DEVICE_ID_RME_DIGI96_8_PAD_OR_PST. > > Signed-off-by: Roland Dreier Thanks. It seems that I submitted an older file. It was intentional to use PCI_DEVICE_ID_DIGI96* to keep the patch smaller. But, PCI_DEVICE_ID_RME_* looks more consistent. Please apply it. Signed-off-by: Takashi Iwai Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/