Date: Wed, 14 Sep 2005 09:24:41 -0700 (PDT)
Message-Id: <20050914.092441.87955714.davem@davemloft.net>
To: nickpiggin@yahoo.com.au
Cc: Linux-Kernel@vger.kernel.org, dipankar@in.ibm.com
Subject: Re: [PATCH 4/5] atomic: dec_and_lock use cmpxchg
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <432839F1.5020907@yahoo.com.au>
References: <4328387E.6050701@yahoo.com.au>
	<432838E8.5030302@yahoo.com.au>
	<432839F1.5020907@yahoo.com.au>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1311
Lines: 29

From: Nick Piggin <nickpiggin@yahoo.com.au>
Date: Thu, 15 Sep 2005 00:55:45 +1000

> I noticed David posted a patch to do something similar the
> other day. With a generic atomic_cmpxchg available, such a
> patch is no longer objectionable to those architectures
> that don't #define __HAVE_ARCH_CMPXCHG
> 
> Do we want this David? Any other architecture have a super
> optimised atomic_dec_and_lock that surpasses this
> implementation?

I talked to Linus about my patch and he made the good point that the
Alpha optimization is very valid (it avoids loading the GP and other
stuff by doing that fancy assembler entry point).  So we decided that
we'd make the cmpxchg() generic version, but make moving over to that
gradual instead of mandatorily forcing everyone to use the new thing.

So, for example, we'd convert sparc64 (because I want to) and the
architectures using the exact same ppc64 C code, but leave the others
alone.  It'd be up to the remaining platform's maintainers to move
over if they wanted to.

I'll submit that updated patch to him later today.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/