Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030278AbVINQw1 (ORCPT ); Wed, 14 Sep 2005 12:52:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030277AbVINQw0 (ORCPT ); Wed, 14 Sep 2005 12:52:26 -0400 Received: from sabe.cs.wisc.edu ([128.105.6.20]:962 "EHLO sabe.cs.wisc.edu") by vger.kernel.org with ESMTP id S1030254AbVINQwZ (ORCPT ); Wed, 14 Sep 2005 12:52:25 -0400 Message-ID: <4328553D.10501@cs.wisc.edu> Date: Wed, 14 Sep 2005 11:52:13 -0500 From: Mike Christie User-Agent: Mozilla Thunderbird 1.0.2-6 (X11/20050513) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alan Stern CC: Anton Blanchard , James Bottomley , Dipankar Sarma , SCSI Mailing List , Linux Kernel Subject: Re: [2.6.14-rc1] sym scsi boot hang References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 36 Alan Stern wrote: > On Wed, 14 Sep 2005, Anton Blanchard wrote: > > >>Hi, >> >> >>>If that's the cause, it's probably a double down of the host scan >>>semaphore somewhere in the code. alt-sysrq-t should work in this case, >>>can you get a stack trace of the blocked process? >> >>It appears to be this patch: >> >> [SCSI] SCSI core: fix leakage of scsi_cmnd's >> >> From: Alan Stern > > >>And in particular it looks like the scsi_unprep_request in >>scsi_queue_insert is causing it. The following patch fixes the boot >>problems on the vscsi machine: > > > In general the scsi_unprep_request routine is correct and needs to be > there. The one part that might be questionable is the assignment to > req->special. It may turn out that the real solution is to have > scsi_execute set req->special to NULL; I assumed it would be NULL already > but perhaps I was wrong. I think we have scsi_execute and friends setting REQ_SPECIAL. This is could cause a problem becuase it does not have a scsi_request. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/