Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030532AbVIOQmX (ORCPT ); Thu, 15 Sep 2005 12:42:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030531AbVIOQmX (ORCPT ); Thu, 15 Sep 2005 12:42:23 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:60304 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1030530AbVIOQmW (ORCPT ); Thu, 15 Sep 2005 12:42:22 -0400 Date: Thu, 15 Sep 2005 17:42:19 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Geert Uytterhoeven , viro@ZenIV.linux.org.uk, Linus Torvalds , linux-arch@vger.kernel.org, Linux Kernel Development Subject: Re: [RFC] killing linux/irq.h Message-ID: <20050915164219.GA31805@infradead.org> Mail-Followup-To: Christoph Hellwig , Matthew Wilcox , Geert Uytterhoeven , viro@ZenIV.linux.org.uk, Linus Torvalds , linux-arch@vger.kernel.org, Linux Kernel Development References: <20050909184254.GT9623@ZenIV.linux.org.uk> <20050915163455.GD16698@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050915163455.GD16698@parisc-linux.org> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 21 On Thu, Sep 15, 2005 at 10:34:55AM -0600, Matthew Wilcox wrote: > On Sun, Sep 11, 2005 at 09:50:38AM +0200, Geert Uytterhoeven wrote: > > On Fri, 9 Sep 2005 viro@ZenIV.linux.org.uk wrote: > > > We get regular portability bugs when somebody decides to include > > > linux/irq.h into a driver instead of asm/irq.h. It's almost always a > > > wrong thing to do and, in fact, causes immediate breakage on e.g. arm. > > > > Wouldn't it be more logical to make linux/irq.h the preferred include? > > Usually the linux/* versions are preferred over the asm/* versions. > > There's almost no reason to want <*/irq.h> in the first place. Almost > all drivers really want Umm, no. doesn't include and variours achitectures have important prototypes in there. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/