Message-ID: <61929.200.141.106.169.1126815191.squirrel@correio.lps.ele.puc-rio.br>
In-Reply-To: <1126790860.19133.75.camel@localhost.localdomain>
References: <61637.200.141.106.169.1126660632.squirrel@correio.lps.ele.puc-rio.br><60519.200.141.106.169.1126727337.squirrel@correio.lps.ele.puc-rio.br><43290893.7070207@pobox.com>
    <1126790860.19133.75.camel@localhost.localdomain>
Date: Thu, 15 Sep 2005 17:13:11 -0300 (BRT)
Subject: Re: libata sata_sil broken on 2.6.13.1
From: izvekov@lps.ele.puc-rio.br
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Jeff Garzik" <jgarzik@pobox.com>, izvekov@lps.ele.puc-rio.br,
       linux-kernel@vger.kernel.org
User-Agent: SquirrelMail/1.4.3a-6.FC2
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 878
Lines: 26

> ata_interrupt checks qc->tf.ctl & ATA_NIEN
>
> Other functions set/reset nIEN in the tf they issue then directly call
> ata_tf_load/ata_exec_* so I don't believe qc->tf.ctl is the correct
> thing to check for non-interrupt status on older type controllers at
> least.
>
> Instead you need to look at ap->last_ctl. But that too looks suspect if
> any kind of reset sets it back to an undefined state.
>

Just tried that, and it doesnt help. Doesnt change behaviour, at least for
my problem.

> Finally I don't see what locks viewing ->tf.ctl/->last_ctl against
> whether it has yet been loaded into the hardware.
>
> Alan
>

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/