Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161212AbVIPSFq (ORCPT ); Fri, 16 Sep 2005 14:05:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161220AbVIPSFq (ORCPT ); Fri, 16 Sep 2005 14:05:46 -0400 Received: from nevyn.them.org ([66.93.172.17]:10988 "EHLO nevyn.them.org") by vger.kernel.org with ESMTP id S1161212AbVIPSFp (ORCPT ); Fri, 16 Sep 2005 14:05:45 -0400 Date: Fri, 16 Sep 2005 14:05:35 -0400 From: Daniel Jacobowitz To: Al Viro Cc: Sripathi Kodi , Al Viro , Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, patrics@interia.pl, Ingo Molnar , Roland McGrath Subject: Re: [PATCH 2.6.13.1] Patch for invisible threads Message-ID: <20050916180535.GA10430@nevyn.them.org> Mail-Followup-To: Al Viro , Sripathi Kodi , Al Viro , Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, patrics@interia.pl, Ingo Molnar , Roland McGrath References: <20050913165102.GR25261@ZenIV.linux.org.uk> <20050913171215.GS25261@ZenIV.linux.org.uk> <43274503.7090303@in.ibm.com> <20050914015003.GW25261@ZenIV.linux.org.uk> <4328C0D0.6000909@in.ibm.com> <20050915011850.GZ25261@ZenIV.linux.org.uk> <432A17E0.3060302@in.ibm.com> <20050916074606.GE19626@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050916074606.GE19626@ftp.linux.org.uk> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 23 On Fri, Sep 16, 2005 at 08:46:06AM +0100, Al Viro wrote: > > Further, about actual permission checks that we are doing, can we say: "A > > process should be able to see /proc//task/* of another process only if > > they both belong to same uid or reader is root"? But any such change will > > change the behavior of commands like 'ps', right? > > Right. The real question is whether the current behaviour makes any sense. > I've no objections to your patch + modification above, but I really wonder > if we should keep current rules in that area. Why should there be any more restrictions on /proc//task than there are in /proc? Threads are not listed in the latter, but that's strictly for performance/usability; you can enumerate threads in /proc by just trying all the valid PIDs. -- Daniel Jacobowitz CodeSourcery, LLC - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/