Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932533AbVISR7v (ORCPT ); Mon, 19 Sep 2005 13:59:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932532AbVISR7v (ORCPT ); Mon, 19 Sep 2005 13:59:51 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:2432 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S932527AbVISR7u (ORCPT ); Mon, 19 Sep 2005 13:59:50 -0400 Date: Tue, 30 Aug 2005 12:18:30 +0100 From: Matthew Wilcox To: Rusty Lynch Cc: Andi Kleen , Christoph Lameter , Rusty Lynch , linux-mm@kvack.org, prasanna@in.ibm.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, anil.s.keshavamurthy@intel.com Subject: Re: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured. Message-ID: <20050830111830.GI26314@parcelfarce.linux.theplanet.co.uk> References: <200508262246.j7QMkEoT013490@linux.jf.intel.com> <200508270224.26423.ak@suse.de> <20050830001905.GA18279@linux.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050830001905.GA18279@linux.jf.intel.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 35 On Mon, Aug 29, 2005 at 05:19:05PM -0700, Rusty Lynch wrote: > So, assuming inlining the notifier_call_chain would address Christoph's > conserns, is the following patch something like what you are sugesting? > This would make all the kdebug.h::notify_die() calls use the inline version. I think we need something more like this ... include/linux/notifier.h: +static inline int notifier_call_chain(struct notifier_block **n, + unsigned long val, void *v) +{ + if (n) + return __notifier_call_chain(n, val, v); + return NOTIFY_DONE; +} kernel/sys.c: -int notifier_call_chain(struct notifier_block **n, unsigned long val, void *v) +int __notifier_call_chain(struct notifier_block **n, unsigned long val, void *v) -EXPORT_SYMBOL(notifier_call_chain); +EXPORT_SYMBOL(__notifier_call_chain); That way everyone gets both the quick test and the global size reduction. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/