Subject: Re: ctime set by truncate even if NOCMTIME requested
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Steve French <smfrench@austin.rr.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <432F2684.4040300@austin.rr.com>
References: <432EFAB1.4080406@austin.rr.com>
	 <1127156303.8519.29.camel@lade.trondhjem.org>
	 <432F2684.4040300@austin.rr.com>
Content-Type: text/plain; charset=utf-8
Date: Mon, 19 Sep 2005 17:28:31 -0400
Message-Id: <1127165311.8519.39.camel@lade.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1219
Lines: 29

må den 19.09.2005 Klokka 15:58 (-0500) skreiv Steve French:
> Trond Myklebust wrote:
> 
> >It is quite correct for the kernel to request that the filesystem set
> >ctime/mtime on successful calls to open(O_TRUNC).
> >  http://www.opengroup.org/onlinepubs/009695399/toc.htm
> >  
> >
> I agree that it is correct to set ctime/mtime here, just not convinced 
> it it worth setting it twice which is what will happen for non-local fs.
> 
> client truncate -> client setattr(for both size and ctime) -> server 
> setattr (which will have a sideffect of ctime to be set on the server, 
> not just the change to file size) and then another call to the server to 
> set the ctime (which will end up setting ctime twice - one to the 
> (correct) server's time and once to the less correct client's time.

If the VFS sets ATTR_[ACM]TIME, you should always assume that you are
being requested to set the [acm]time to server time. Doesn't CIFS allow
you that option?

Cheers,
  Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/