Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932551AbVITFEh (ORCPT ); Tue, 20 Sep 2005 01:04:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932726AbVITFEh (ORCPT ); Tue, 20 Sep 2005 01:04:37 -0400 Received: from smtp103.rog.mail.re2.yahoo.com ([206.190.36.81]:58022 "HELO smtp103.rog.mail.re2.yahoo.com") by vger.kernel.org with SMTP id S932551AbVITFEg (ORCPT ); Tue, 20 Sep 2005 01:04:36 -0400 Subject: Re: [patch] stop inotify from sending random DELETE_SELF event under load From: John McCutchan To: Al Viro Cc: Linus Torvalds , Andrew Morton , Linux Kernel , Robert Love , Al Viro In-Reply-To: <20050920045835.GE7992@ftp.linux.org.uk> References: <1127177337.15262.6.camel@vertex> <1127181641.16372.10.camel@vertex> <1127188015.17794.6.camel@vertex> <20050920042456.GC7992@ftp.linux.org.uk> <1127190971.18595.5.camel@vertex> <20050920044623.GD7992@ftp.linux.org.uk> <1127191992.19093.3.camel@vertex> <20050920045835.GE7992@ftp.linux.org.uk> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 20 Sep 2005 01:06:23 -0400 Message-Id: <1127192784.19093.7.camel@vertex> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 25 On Tue, 2005-09-20 at 05:58 +0100, Al Viro wrote: > On Tue, Sep 20, 2005 at 12:53:12AM -0400, John McCutchan wrote: > > DELETE_SELF WD=X > > > > The path you requested a watch on (inotify_add_watch(path,mask) returned > > X) has been deleted. > > Then why the devil do we have IN_DELETE and IN_DELETE_SELF generated > in different places? The only difference is in who receives the > event - you send IN_DELETE to watchers on parent and IN_DELETE_SELF > on watchers on victim. Event itself is the same, judging by your > description... No, because in the case of IN_DELETE, the path represented by the WD hasn't been deleted, it is "PATH(WD)/event->name" that has been. Also, IN_DELETE_SELF marks the death of the WD, no further events will be sent with the same WD [Except for the IN_IGNORE]. -- John McCutchan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/