Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964911AbVITIdb (ORCPT ); Tue, 20 Sep 2005 04:33:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964928AbVITIdb (ORCPT ); Tue, 20 Sep 2005 04:33:31 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:14562 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S964911AbVITId3 (ORCPT ); Tue, 20 Sep 2005 04:33:29 -0400 Date: Tue, 20 Sep 2005 09:33:27 +0100 From: Christoph Hellwig To: Linus Torvalds Cc: John McCutchan , Andrew Morton , Linux Kernel , Robert Love , Al Viro Subject: Re: [patch] stop inotify from sending random DELETE_SELF event under load Message-ID: <20050920083327.GA31209@infradead.org> Mail-Followup-To: Christoph Hellwig , Linus Torvalds , John McCutchan , Andrew Morton , Linux Kernel , Robert Love , Al Viro References: <1127177337.15262.6.camel@vertex> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 34 On Mon, Sep 19, 2005 at 06:37:43PM -0700, Linus Torvalds wrote: > > > On Mon, 19 Sep 2005, John McCutchan wrote: > > > > Below is a patch that fixes the random DELETE_SELF events when the > > system is under load. The problem is that the DELETE_SELF event is sent > > from dentry_iput, which is called in two code paths, > > > > 1) When a dentry is being deleted > > 2) When the dcache is being pruned. > > No no. > > The problem is that you put the "fsnotify_inoderemove(inode);" in the > wrong place, and I and Al never noticed. > > iput() doesn't have anything to do with delete at all, and adding a flag > to it would be wrong. The inode may stay around _after_ the unlink() for > as long as it has users (or much longer, if you have hardlinks ;). > > You should probably move the "fsnotify_inoderemove(inode);" call into > generic_delete_inode() instead, just after "security_inode_delete()". No > new flags, just a new place. > > (Oh, I think you need to add it to "hugetlbfs_delete_inode()" too). I have a patch pending to kill hugetlbfs_delete_inode(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/