Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965062AbVITSmR (ORCPT ); Tue, 20 Sep 2005 14:42:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965065AbVITSmQ (ORCPT ); Tue, 20 Sep 2005 14:42:16 -0400 Received: from mail.dvmed.net ([216.237.124.58]:11927 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S965062AbVITSmQ (ORCPT ); Tue, 20 Sep 2005 14:42:16 -0400 Message-ID: <433057E9.5060905@pobox.com> Date: Tue, 20 Sep 2005 14:41:45 -0400 From: Jeff Garzik User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Russell King CC: Andrew Morton , Alan Cox , penberg@cs.Helsinki.FI, viro@ftp.linux.org.uk, linux-kernel@vger.kernel.org, torvalds@osdl.org Subject: Re: p = kmalloc(sizeof(*p), ) References: <20050918100627.GA16007@flint.arm.linux.org.uk> <84144f0205092004187f86840c@mail.gmail.com> <20050920114003.GA31025@flint.arm.linux.org.uk> <20050920123149.GA29112@flint.arm.linux.org.uk> <20050920101128.70fec697.akpm@osdl.org> <1127239361.7763.3.camel@localhost.localdomain> <20050920105939.3c9c5e39.akpm@osdl.org> <20050920181144.GD493@flint.arm.linux.org.uk> In-Reply-To: <20050920181144.GD493@flint.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 38 Russell King wrote: > On Tue, Sep 20, 2005 at 10:59:39AM -0700, Andrew Morton wrote: > >>>"I want to grep for >>>initialisations" is pretty pointless because a) it won't catch everything >>>anyway and b) most structures are allocated and initialised at a single >>>place and many of those which aren't should probably be converted to do >>>that anyway. >>> >>>The broader point is that you're trying to optimise for the wrong thing. >>>We should optimise for those who read code, not for those who write it. >>> >> >>If you look back, your five reasons tend to address modifiability, not >>readability. > > > So what you're saying is that we should optimise the code so that > we make mistakes when we modify it. Umm, yes, of course. > > This is a contentious issue, and I don't think anyone should be > stipulating which way is the right way - which is exactly what > has been done by placing it in Coding Style. Remember, we have > kernel janitors who _will_ change code to match that. Precisely. Since there is enough disagreement, it lacks consensus to be in CodingStyle. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/