Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965098AbVITThc (ORCPT ); Tue, 20 Sep 2005 15:37:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965099AbVITThc (ORCPT ); Tue, 20 Sep 2005 15:37:32 -0400 Received: from smtp.osdl.org ([65.172.181.4]:24762 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S965098AbVITThc (ORCPT ); Tue, 20 Sep 2005 15:37:32 -0400 Date: Tue, 20 Sep 2005 12:37:02 -0700 (PDT) From: Linus Torvalds To: Al Viro cc: Ray Lee , John McCutchan , Andrew Morton , Linux Kernel , Robert Love , Al Viro Subject: Re: [patch] stop inotify from sending random DELETE_SELF event under load In-Reply-To: <20050920182249.GP7992@ftp.linux.org.uk> Message-ID: References: <1127190971.18595.5.camel@vertex> <20050920044623.GD7992@ftp.linux.org.uk> <1127191992.19093.3.camel@vertex> <20050920045835.GE7992@ftp.linux.org.uk> <1127192784.19093.7.camel@vertex> <20050920051729.GF7992@ftp.linux.org.uk> <76677C3D-D5E0-4B5A-800F-9503DA09F1C3@tentacle.dhs.org> <20050920163848.GO7992@ftp.linux.org.uk> <1127238257.9940.14.camel@localhost> <20050920182249.GP7992@ftp.linux.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 27 On Tue, 20 Sep 2005, Al Viro wrote: > > > > I really think that the patch I sent out yesterday is as good as it gets. > > If you want immediate notification, you should ask for notification about > > name changes in a particular directory. IN_DELETE_SELF notification on a > > file simple is _not_ going to be immediate. > > But then it's too early. Note that with your patch we still get removal > of _any_ link to our inode (even though it's alive and well and we'd never > heard about the sodding link in the first place) terminating all events > on it. Yes. What is in the current 2.6.14-rc2 tree doesn't do that. It considers inodes "global". But it won't work reliably on networked filesystems, I think. Anyway, I do believe that IN_DELETE_SELF is stupid, but that you migth re-arm it if you get it. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/