Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965121AbVITVJT (ORCPT ); Tue, 20 Sep 2005 17:09:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965122AbVITVJT (ORCPT ); Tue, 20 Sep 2005 17:09:19 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:4821 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S965121AbVITVJT (ORCPT ); Tue, 20 Sep 2005 17:09:19 -0400 Date: Tue, 20 Sep 2005 23:06:17 +0200 From: Pavel Machek To: "Eric W. Biederman" Cc: Linus Torvalds , len.brown@intel.com, Pierre Ossman , acpi-devel@lists.sourceforge.net, ncunningham@cyclades.com, Masoud Sharbiani , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] suspend: Cleanup calling of power off methods. Message-ID: <20050920210617.GA1779@elf.ucw.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 21 Hi! > In the lead up to 2.6.13 I fixed a large number of reboot > problems by making the calling conventions consistent. Despite > checking and double checking my work it appears I missed an > obvious one. > > The S4 suspend code for PM_DISK_PLATFORM was also calling > device_shutdown without setting system_state, and was > not calling the appropriate reboot_notifier. ACK on both. But should not you submit patch via -mm, so it gets at least some testing there? Pavel -- if you have sharp zaurus hardware you don't need... you know my address - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/