Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751358AbVIUS0a (ORCPT ); Wed, 21 Sep 2005 14:26:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751359AbVIUS03 (ORCPT ); Wed, 21 Sep 2005 14:26:29 -0400 Received: from frankvm.xs4all.nl ([80.126.170.174]:58019 "EHLO janus.localdomain") by vger.kernel.org with ESMTP id S1751358AbVIUS03 (ORCPT ); Wed, 21 Sep 2005 14:26:29 -0400 Date: Wed, 21 Sep 2005 20:26:27 +0200 From: Frank van Maarseveen To: Jay Lan Cc: Hugh Dickins , Frank van Maarseveen , Christoph Lameter , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss Message-ID: <20050921182627.GB17272@janus> References: <20050921121915.GA14645@janus> <43319111.1050803@engr.sgi.com> <4331990A.80904@engr.sgi.com> <4331A0DA.5030801@engr.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4331A0DA.5030801@engr.sgi.com> User-Agent: Mutt/1.4.1i X-Subliminal-Message: Use Linux! Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 33 On Wed, Sep 21, 2005 at 11:05:14AM -0700, Jay Lan wrote: > > System accounting improvement is needed because those accouting > information were needed and used at real customer sites. > > So, yes, the basic system accounting code (ie, BSD) needs > improvement, and, no, i am done with sys acct data collection. Ok, but how do you verify that the mm->hiwater_* counters are correct to any degree? because it appears that at least hiwater_vm is incorrect in post-2.6.11 and not by a small amount. What about calling static inline void grow_total_vm(struct mm_struct *mm, unsigned long increase) { mm->total_vm += increase; if (mm->total_vm > mm->hiwater_vm) mm->hiwater_vm = mm->total_vm; } whenever total_vm is increased and possibly doing something similar for rss at different places? If it is not on the fast path then it's not necessary to #ifdef the thing anywhere. -- Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/