Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964822AbVIUV2s (ORCPT ); Wed, 21 Sep 2005 17:28:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964965AbVIUV2s (ORCPT ); Wed, 21 Sep 2005 17:28:48 -0400 Received: from lakshmi.addtoit.com ([198.99.130.6]:15624 "EHLO lakshmi.solana.com") by vger.kernel.org with ESMTP id S964822AbVIUV2s (ORCPT ); Wed, 21 Sep 2005 17:28:48 -0400 Date: Wed, 21 Sep 2005 16:52:27 -0400 From: Jeff Dike To: "Paolo 'Blaisorblade' Giarrusso" Cc: user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [uml-devel] [PATCH 08/10] uml: Fix GFP_ flags usage Message-ID: <20050921205227.GC9918@ccure.user-mode-linux.org> References: <200509211923.21861.blaisorblade@yahoo.it> <20050921172920.10219.29856.stgit@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050921172920.10219.29856.stgit@zion.home.lan> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 533 Lines: 14 On Wed, Sep 21, 2005 at 07:29:21PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > - if(atomic) flags |= GFP_ATOMIC; > + if (atomic) > + flags = GFP_ATOMIC; We should take a careful look at where this is called from, and see if we can get rid of the atomic business altogether. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/