Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030203AbVIVDi2 (ORCPT ); Wed, 21 Sep 2005 23:38:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030204AbVIVDi2 (ORCPT ); Wed, 21 Sep 2005 23:38:28 -0400 Received: from rwcrmhc14.comcast.net ([216.148.227.89]:670 "EHLO rwcrmhc12.comcast.net") by vger.kernel.org with ESMTP id S1030203AbVIVDi2 (ORCPT ); Wed, 21 Sep 2005 23:38:28 -0400 Subject: Re: [PATCH] bogus #if (acpi/blacklist) From: Len Brown To: Roman Zippel Cc: viro@ZenIV.linux.org.uk, Eric Piel , Linus Torvalds , linux-kernel@vger.kernel.org In-Reply-To: References: Content-Type: text/plain Date: Thu, 15 Sep 2005 18:05:15 -0400 Message-Id: <1126821915.31252.10.camel@toshiba> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 27 On Fri, 2005-09-09 at 12:55 -0400, Roman Zippel wrote: > Hi, > > On Fri, 9 Sep 2005 viro@ZenIV.linux.org.uk wrote: > > > Sigh... It should be left as #if, of course, but I suspect that > cleaner way to > > deal with that would be (in Kconfig) > > > > config ACPI_BLACKLIST_YEAR > > int "Disable ACPI for systems before Jan 1st this year" if > X86 > > default 0 > > That would be indeed the better fix. The real bug is that drivers/acpi/blacklist.c (the only place CONFIG_ACPI_BLACLIST_YEAR is referenced) is compiled for non X86. -Len - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/