Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751042AbVIVHhs (ORCPT ); Thu, 22 Sep 2005 03:37:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751433AbVIVHhs (ORCPT ); Thu, 22 Sep 2005 03:37:48 -0400 Received: from mailout1.vmware.com ([65.113.40.130]:22789 "EHLO mailout1.vmware.com") by vger.kernel.org with ESMTP id S1751042AbVIVHhr (ORCPT ); Thu, 22 Sep 2005 03:37:47 -0400 Date: Thu, 22 Sep 2005 00:37:20 -0700 Message-Id: <200509220737.j8M7bKgh000928@zach-dev.vmware.com> Subject: [PATCH 1/3] Bogus tls from gdt From: Zachary Amsden To: Linus Torvalds , Jeffrey Sheldon , Ole Agesen , Shai Fultheim , Andrew Morton , Jack Lo , Ingo Molnar , Linux Kernel Mailing List , Virtualization Mailing List , Chris Wright , Martin Bligh , Pratap Subrahmanyam , Christopher Li , "H. Peter Anvin" , Zwane Mwaikambo , Andi Kleen , Zachary Amsden From: Zachary Amsden X-OriginalArrivalTime: 22 Sep 2005 07:37:19.0758 (UTC) FILETIME=[768F4AE0:01C5BF48] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1208 Lines: 29 The per-CPU initialization code is copying in bogus data into thread->tls_array. Note that it copies &per_cpu(cpu_gdt_table, cpu), not &per_cpu(cpu_gdt_table, cpu)[GDT_ENTRY_TLS_MIN). That is totally broken and unnecessary. Make the initialization explicitly NULL. Signed-off-by: Zachary Amsden Index: linux-2.6.14-rc1/arch/i386/kernel/cpu/common.c =================================================================== --- linux-2.6.14-rc1.orig/arch/i386/kernel/cpu/common.c 2005-09-20 14:49:10.000000000 -0700 +++ linux-2.6.14-rc1/arch/i386/kernel/cpu/common.c 2005-09-20 14:49:41.000000000 -0700 @@ -607,12 +607,6 @@ void __devinit cpu_init(void) cpu_gdt_descr[cpu].address = (unsigned long)&per_cpu(cpu_gdt_table, cpu); - /* - * Set up the per-thread TLS descriptor cache: - */ - memcpy(thread->tls_array, &per_cpu(cpu_gdt_table, cpu), - GDT_ENTRY_TLS_ENTRIES * 8); - load_gdt(&cpu_gdt_descr[cpu]); load_idt(&idt_descr); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/